Closed hossman closed 7 years ago
I didn't get a chance to checkout the branch and run it so my concern may be misplaced, but the only real concern I have structure-wise is that the solr-ref-guide/src/pdf
directory will get built and converted to HTML when the Jekyll job is run. If build.xml protects against that, this structure is fine to go forward with.
... the only real concern I have structure-wise is that the solr-ref-guide/src/pdf directory will get built and converted to HTML when the Jekyll job is run ...
There's exclusion rules in _config.yml
to prevent that.
(the main reason i put thepdf
stuff in src/pdf
is that it helps keep the paths sane, so when you're looking at the pdf ant task, you're not jumping through hoops to try and make sense of what directory the various paths are resolved against)
There's exclusion rules in
_config.yml
to prevent that.
Yeah, OK, I see that. That should be fine, then. I agree putting it in the same tree is easier and more straightforward.
more progress for issue #5
this re-organizes the files much more severely, trying to move everything we expect to be in the final git repo into a single directory, islolated from the "conversion" tools we'll throw away once we've done the final migration.
there still some more stuff to do - notably switching all the jar fetching to use ivy -- but i wanted to get this branch i've been working on up on github so @ctargett could look it over nad let me know if she thinks this is the right direction to be heading.