search

ctasada / GWT-Eureka

GWT widgets and utilities library
Apache License 2.0
12 stars 8 forks source link

Time Picker cannot decrease #7

Closed ericcitaire closed 11 years ago

ericcitaire commented 11 years ago

When minutes are greater than zero (ie. 45) and the user try to decrease the time using arrows or the mouse-wheel on the minutes field, it stops decreasing (ie. at 00:45).

This is due to a condition in decreaseValue(), which seems to intend to block the decreasing at 00:00. It doesn't work and I think it's not necessary to block at 00:00. BTW, the same condition in increaseValue() doesn't work either. I suggest we drop these conditions.

ctasada commented 11 years ago

Hi Eric,

Thanks for reporting this bug, but for some reason I cannot replicate it. Can you give me an step by step replication? Is happening in all browsers? can you replicate using http://gwt-eureka.appspot.com?

I've applied your patch, but I don't see any change in the behaviour.

Thanks again

ericcitaire commented 11 years ago

Hi,

Yes, you can replicate the bug on http://gwt-eureka.appspot.com/. The easiest way is to decrease the minutes with the mouse-wheel in the first Small TimePicker example (it's easier because it decreases faster). Decrease it until you get 00:45, and then you're stuck here.

I was able to reproduce this in Chrome, Firefox and IE.

Eric.

ctasada commented 11 years ago

Thanks a lot Eric, it worked like a charm!