search

ctb / twill-legacy

A simple command-line Web browser, for testing and Web automation.
https://twill-tools.github.io/twill
58 stars 28 forks source link

Mechanize -> Requests #5

Closed brtaylor92 closed 10 years ago

brtaylor92 commented 10 years ago

As requested

brtaylor92 commented 10 years ago

Things I'd like feedback on: 1) Authentication realms 2) Referrers 3) Meta-refreshes?

ctb commented 10 years ago

Can you increment the version number in setup.py? I would go for 1.8 :)

ctb commented 10 years ago

Yes, the test-form test should fail, because 'value' is not a valid value for the form. We could make this clearer by using INVALIDVALUE, e.g.

commands.fv('1', 'selecttest', 'INVALIDVALUE')

So this is a test that should be fixed; 'fv' should raise a TwillException here.

ctb commented 10 years ago

Fix that and I'll do a slightly more in depth code review :)