ctc-oss / fapolicy-analyzer

Tools to assist with the configuration and management of fapolicyd.
https://ctc-oss.github.io/fapolicy-analyzer
GNU General Public License v3.0
13 stars 5 forks source link

Color change for Analysis Objects #685

Closed jw3 closed 1 year ago

jw3 commented 1 year ago

In the context of the Object column the orange color is used for all allowed executions.

Change the color coding to represent:

egbicker commented 1 year ago

@jw3 In the meeting there was a decision to make objects that are untrusted (U) but allowed (A) orange/warning. If an object is untrusted (Red ST) but allowed should we also mark it orange/warning?

jw3 commented 1 year ago

If an object is untrusted (Red ST) but allowed should we also mark it orange/warning?

That sounds right. Any type of U with A is a warning.

dorschs57 commented 1 year ago

Code wise I think orange should be the default fall through color. If something is deny (D) it's red. If it's trusted either (green ST) or (green AT) and allowed (A) then it's green. Anything else should probably be orange. Seem right @jw3?

jw3 commented 1 year ago

Code wise I think orange should be the default fall through color. If something is deny (D) it's red. If it's trusted either (green ST) or (green AT) and allowed (A) then it's green. Anything else should probably be orange. Seem right @jw3?

Yes, sounds like that covers all cases