ctc-oss / fapolicy-analyzer

Tools to assist with the configuration and management of fapolicyd.
https://ctc-oss.github.io/fapolicy-analyzer
GNU General Public License v3.0
12 stars 5 forks source link

Add the daemon config UI #909

Closed egbicker closed 11 months ago

egbicker commented 12 months ago

Adds the user interface components for fapolicyd configuration editing and deployment.

Closes #830

egbicker commented 12 months ago

@jw3 I'm trying to implement the ConfigChangeset but even after rebuilding the rust layer I'm still getting AttributeError: module 'fapolicy_analyzer' has no attribute 'ConfigChangeset'

jw3 commented 12 months ago

@jw3 I'm trying to implement the ConfigChangeset but even after rebuilding the rust layer I'm still getting AttributeError: module 'fapolicy_analyzer' has no attribute 'ConfigChangeset'

I missed a registration call in #908. #910 adds it and adds an example config changest usage.

jw3 commented 11 months ago

:heavy_check_mark: ~Deployment nearly working, needs #911~


There is also something going on that causes the unsaved rule changes dialog to always pop up, even when no rules have been edited.

jw3 commented 11 months ago

@egbicker do you have tests coming for the new stuff?

egbicker commented 11 months ago

@jw3 Just got them pushed

jw3 commented 11 months ago

Added #912 describing some related concerns. Doesnt have to be fixed for this PR, but could be if simple enough.

Another thought with this is that the unsaved rule edit check would apply to config as well.

egbicker commented 11 months ago

@jw3 I believe we'd need a binding like rules_difference

jw3 commented 11 months ago

913 is on the way