feat: sandbox id generation was producing useless cycles.

ctdk / goiardi

A Chef server written in Go, able to run entirely in memory, with optional persistence with saving the in-memory data to disk or using MySQL or Postgres as the data storage backend. Docs: http://goiardi.readthedocs.io/en/latest/index.html

http://goiardi.gl

Apache License 2.0

280 stars 39 forks source link

feat: sandbox id generation was producing useless cycles. #69

Closed alekc closed 4 years ago

alekc commented 4 years ago

What, if anything, does this fix? (If there's an existing issue, link it here.) Sandbox id generation was using all 5 cycles even if it found a good id on the first run
What is the new behavior (if this is a feature change)? break the loop earlier in case we got what we need.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) no

ctdk commented 4 years ago

Welp, that was a clown error on my part. Hangs head in shame Thanks once more.