Closed alekc closed 4 years ago
I'll run this one through the tests and make sure it doesn't break those somehow. I've finally started moving goiardi over to using the current chef-pedant instead of a rather out of date one, which is proving to be "interesting" to say the least.
Thanks, and I'll try and get this turned around soon.
Sounds good to me
On Thu, 23 Jul 2020 at 17:45, Jeremy Bingham notifications@github.com wrote:
I'll run this one through the tests and make sure it doesn't break those somehow. I've finally started moving goiardi over to using the current chef-pedant instead of a rather out of date one, which is proving to be "interesting" to say the least.
Thanks, and I'll try and get this turned around soon.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ctdk/goiardi/pull/76#issuecomment-663113080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJ5V3PKOBMMB3BZSYHQ5TR5BSLDANCNFSM4PFTSFGA .
What, if anything, does this fix? See https://github.com/ctdk/goiardi/issues/75
What kind of change does this PR introduce? BugFix
What is the new behavior (if this is a feature change)? Additional fields has been added to a list of a valid fields, if password is null its being treaded as empty.
Does this PR introduce a breaking change? no