ctelroy / rapidjson

Automatically exported from code.google.com/p/rapidjson
MIT License
0 stars 0 forks source link

Fix of some clang warnings #102

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Compiling an empty program that includes rapidjson with clang -Weverything 
leads to 
warning related to typos and syntax problems in the doxygen commands
The trivial patch attached resolves the issue.
Another warning persists but I believe it's a false positive. It could be nice, 
however, to be able to compile
warnings-free with -Weverything (a policy in my project) even if it the 
compiler wrong here.
The problem is that you use the \implements command to inform the 
implementation of a concept by a class, 
while clang checks that the actual inheritance relationship. The second patch 
fix the controversial warning.

Original issue reported on code.google.com by nicola.g...@gmail.com on 7 Mar 2014 at 4:42

Attachments:

GoogleCodeExporter commented 8 years ago
EDIT: The second attached patch fixes only one of the points where the issue 
arise, just to give an example

Original comment by nicola.g...@gmail.com on 7 Mar 2014 at 4:49

GoogleCodeExporter commented 8 years ago

Original comment by milo...@gmail.com on 20 Jun 2014 at 11:21

GoogleCodeExporter commented 8 years ago
This commit should have fixed some warnings. This commit has been merged to 
master branch.

https://github.com/miloyip/rapidjson/commit/be8433737fde41827ab8b7c9477b75c10661
e049

Original comment by milo...@gmail.com on 30 Jun 2014 at 5:14