ctengel / linkmeddle

LINKed MEDia DL
GNU General Public License v3.0
0 stars 0 forks source link

ytdlp? #63

Closed ctengel closed 2 years ago

ctengel commented 2 years ago

https://github.com/yt-dlp/yt-dlp/tree/master/ytdlp_plugins

ctengel commented 2 years ago

For now just doing latest from git of ytdl to complete #66

ctengel commented 2 years ago

hmm

[2022-06-04 07:18:40,973: INFO/MainProcess] Received task: tasks.download[abc]
[2022-06-04 07:18:40,980: WARNING/Worker-1] WARNING: Support for Python version 3.5 have been deprecated and will break in future versions of yt-dlp! Update to Python 3.6 or above
[2022-06-04 07:18:43,452: WARNING/Worker-1] [youtube] xyz: Downloading webpage
[2022-06-04 07:18:43,920: WARNING/Worker-1] [youtube] xyz: Refetching age-gated info webpage
[2022-06-04 07:18:44,051: WARNING/Worker-1] WARNING: [youtube] unable to download video info webpage: HTTP Error 410: Gone
[2022-06-04 07:18:44,057: WARNING/Worker-1] ERROR: Sign in to confirm your age
This video may be inappropriate for some users.
[2022-06-04 07:18:44,062: INFO/MainProcess] Task tasks.download[abc] succeeded in 3.0858438550058054s: {'data': None, 'ignoreerrors': False, 'url': 'https://www.youtube.com/watch?v=xyz', 'error': 'ERROR: Sign in to...

vs

$ yt-dlp --write-info-json --write-thumbnail --write-subs https://www.youtube.com/watch?v=xyz
[youtube] xyz: Downloading webpage
[youtube] xyz: Downloading android player API JSON
[youtube] xyz: Downloading tv embedded player API JSON
[youtube] xyz: Downloading web embedded client config
[youtube] xyz: Downloading player 123
[youtube] xyz: Downloading web embedded player API JSON
[info] xyz: Downloading 1 format(s): 247+251
[info] Downloading video thumbnail 45 ...
[info] Writing video thumbnail 45 to: xyz.webp
[info] Writing video metadata as JSON to: zyz.info.json
[download] Destination: xyz.f247.webm
[download] 100% of 1.1 MiB in 00:09
[download] Destination: xyz.f251.webm
[download] 100% of 1.1KiB in 00:00
[Merger] Merging formats into "xyz.webm"
Deleting original file xyz.f251.webm (pass -k to keep)
Deleting original file xyz.f247.webm (pass -k to keep)
ctengel commented 2 years ago

One of two things is likely happening

ctengel commented 2 years ago

https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/extractor/youtube.py

ctengel commented 2 years ago

It's clearly still following https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/extractor/youtube.py ...

ctengel commented 2 years ago
  1. Look at installed code
  2. Uninstall legacy ytdl
ctengel commented 2 years ago

We are capped at yt-dlp 2021.06.01 on Python 3.5.

Therefore need to move to 3B+ with SSD - need to make sure we get metadata over in a way consistent with #70

ctengel commented 2 years ago

Upon moving to Python 3.9 (believed all 3.6+ is OK still) it began working seamlessly as a drop in replacement for ytdl.