Closed rbnhtl closed 3 years ago
@rbnhtl Thank you very much. It looks perfect.
Hi again @rbnhtl,
After giving it some thoughts, I understand that this feature aims at using the exif data of the image to automatically rotate the image to the right orientation.
My suggestion of using the word rotatable
therefore doesn't sound as appropriate as I thought.
What do you think of using autoOrientate
? Otherwise, orientate
can work as it is the term used by Intervention.
Thank you
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Please add this PR
Hi @rbnhtl
Thank you again for your work. This has been added to v1.3.0.
Have a good day Clément
(Closes #62)
Thanks @rbnhtl!
Hi, Thanks for your package!
Images taken from a mobile device often contains exif data to store the image orientation. Uploading portrait images with orientation informations in the exif data in the advanced image field causes the image to rotate and have a black border.
This PR allows the use of intervention orientable method on TransformableImage, which takes into account the orientation stored in the exif data.
However the exif extension must be enabled on the PHP install. This code throws an exception when calling the orientable method if the extension is not loaded. I also changed the composer.json to include the exif extension in the suggest block.
Do you want me to update the readme to mention the exif package use ?
This is my first code PR, let me know if there are any problems.