New feature added and new config item.

[mackenzie-remote]

Hello - firstly thanks for the module, it has saved us a lot of work!

I hit an issue though on Ubuntu 14.04 PBIS "pbis-open-8.0.0.2016.linux.x86_64.deb.sh" the service name that is configured in the module (lsass) does not match the service that this version seems to install (lwsmd). I made the service name a configurable parameter.

I also added a new variable to the pbis.conf.erb template - namely RequireMembershipOf.

Cheers, kenzeh

[benwebber]

Hi kenzeh,

Sorry, I didn't see your pull request until today. Thanks for submitting it.

Everything looks great, except for a minor style nitpick. The new require_membership_of parameter should be either undef or a string, not a boolean or string.

As an example:

class pbis::params {
  $require_membership_of = undef
}

<% if @require_membership_of -%>RequireMembershipOf: "<%= require_membership_of -%>"<% end -%>

Thanks,

Ben

[mackenzie-remote]

Thanks for the feedback - it looks a lot cleaner now.

[benwebber]

Merged, thanks!