ctf0 / Laravel-Media-Manager

A "Vuejs & Laravel" Media Manager With Tons of Features
MIT License
829 stars 179 forks source link

[Feature] support the new flysystem v3 #159

Closed ctf0 closed 1 year ago

ctf0 commented 3 years ago

https://flysystem.thephpleague.com/v2/docs/what-is-new/ https://flysystem.thephpleague.com/docs/upgrade-from-1.x/

jasperf commented 3 years ago

We did experiment with storing images directly on DigitalOcean Spaces using composer require league/flysystem-aws-s3-v3 . We had rate limiting issues however using Spaces. Each image is stored in 5 versions and on each media modal load all images would be displayed with thumbnails. Many , many requests all the time. Did read you mentioned https://github.com/thephpleague/flysystem-cached-adapter in another thread and that may help limiting the requests for the stored images. We did not experiment with that yet. Looking forward to reading on this enhancement and willing to help out with testing for sure.

ctf0 commented 3 years ago

that may help limiting the requests for the stored images. We did not experiment with that yet

highly recommended to use the cache-adapter

Looking forward to reading on this enhancement and willing to help out with testing for sure

probably not b4 next version of laravel v9 https://packagist.org/packages/laravel/framework#dev-master

jasperf commented 3 years ago

Understood the new Flysytem[1][2] has a lot of new advantages:

which would also make cloud storage work better without hitting 503s. Also understood that cached adapter will no longer be supported [3]. Perhaps because of all these new enhancements.

Still looking into delayed jobs, throttling and exponential back-offs [4], but I do feel like Flysystem 2 is going to help out a lot. I see it has been merged[5] into Laravel Master already. The release is however not until September 2021 so we may try out Flysystem 2 sooner than that. Still debating this. But looking at the Laravel Master branch file changes needed we may have to wait.