ctf0 / Laravel-Media-Manager

A "Vuejs & Laravel" Media Manager With Tons of Features
MIT License
829 stars 179 forks source link

Fix sortBy:size To Work Properly With (kb vs Mb). #6

Closed chriys closed 6 years ago

chriys commented 6 years ago

Can you please give more explanation to this issue?

ctf0 commented 6 years ago

atm the filter we use to sort the items by size doesnt understand the kb vs Mb and it only looks at numbers, ex

[
{file 1: '980kb'},
{file 2: '7 Mb'},
{file 3: '500kb'}, 
'etc...'
]

https://github.com/freearhey/vue2-filters/issues/20

chriys commented 6 years ago

Ok I get it. I'm looking their code souce. Could you please specify where you're calling the filter orderBy inside script.js ?

ctf0 commented 6 years ago

its used in the view file as its a part of the vue2-filters package https://github.com/ctf0/Laravel-Media-Manager/blob/master/src/resources/views/bulma/media.blade.php#L242

chriys commented 6 years ago

do you mind if we tweak their functionality to suit our needs ?

ctf0 commented 6 years ago

plz, go for it. :+1:

ctf0 commented 6 years ago

check next release