Adding functionality to detect when combining file(s).

ctf0 / laravel-mix-versionhash

Auto append hash to file instead of using virtual one

MIT License

61 stars 18 forks source link

Closed Erutan409 closed 5 years ago

Erutan409 commented 5 years ago

Uses built-in Laravel Mix hashing functionality
Implements a webpack plugin that will update the stats asset listing for combined file(s)

This closes #10

Erutan409 commented 5 years ago

@ctf0 I'll pull the suffixed semi-colons after you look at what I added. Having them there is easier for me to follow logic when I'm developing.

ctf0 commented 5 years ago

many many thanx for ur hard work, could u plz remove the extra semicolon & empty lines to have a better overview of what was actually changed ?

Erutan409 commented 5 years ago

You're welcome. I'll remove the semi-colons, but I'll let you remove the blank lines as I'm sure you have your own preference.

Erutan409 commented 5 years ago

@ctf0 Also - may I suggest bumping this to v1.1.0 for this not necessarily being a bug fix?

ctf0 commented 5 years ago

np, thanx again

ctf0 commented 5 years ago

@Erutan409 i've made a couple of changes, plz check latest commits and reply back 👍

Erutan409 commented 5 years ago

@Erutan409 i've made a couple of changes, plz check latest commits and reply back 👍

Everything looked good to me 👍

Erutan409 commented 5 years ago

@ctf0 Is this good to go for publishing to NPM?

ctf0 commented 5 years ago

will publish it today once i get home 👍

ctf0 commented 5 years ago

@Erutan409 done

Erutan409 commented 5 years ago

@ctf0 You're missing an apostrophe after this line. You should correct this ASAP.