ctf0 / laravel-mix-versionhash

Auto append hash to file instead of using virtual one
MIT License
61 stars 18 forks source link

Fix: Prevents other plugins to tap on done hook #50

Closed devbkhadka closed 1 year ago

devbkhadka commented 1 year ago

It was using compiler.hooks.done.tapAsync to back slash to replace backslash with forward-slash. Because the function was not calling the callback for plugins chain to continue it was preventing other plugins from getting done hooks event.

As we are only doing synchronous work in that function I used compiler.hooks.done.tap instead.

ctf0 commented 1 year ago

thank you so much.