search

ctgk / PRML

PRML algorithms implemented in Python
MIT License
11.43k stars 3.25k forks source link

An issue in gaussian mixture #29

Open quantumiracle opened 4 years ago

quantumiracle commented 4 years ago

Hi, Should it be the inverse of covariance matrix here? https://github.com/ctgk/PRML/blob/47d9830b39e91690cedb27003934df85cfb8c5c7/prml/rv/multivariate_gaussian_mixture.py#L124 i.e. D_sq = np.sum(np.einsum('nki,kij->nkj', d, np.linalg.inv(self.cov)) * d, -1)

ctgk commented 2 years ago

Thanks for your comment! That is my mistake. I'll fix it.