cthit / chalmers.it

A 2023/2024 rewrite of the main website of the Software Engineering (IT) student division at Chalmers
https://beta.chalmers.it
1 stars 1 forks source link

Login and logout UI #37

Closed GAsplund closed 4 months ago

GAsplund commented 4 months ago

Key features:

Known issues:

GAsplund commented 4 months ago

Everything seams to work as expected. I like that the "Min Profil" links to the gamma profile edit page! The one thing I was thinking was that maybe we want to have a tool tip or something similar that displays the logged in users nick when hovering the profile picture? Or maybe having the nick in the drop down? I don't see this as a must for this PR so if we want to do this later I am ready to approve in it's current state.

Great points! Having discussed different design choices with @Tussies, we agreed that the nick should probably be displayed somewhere else on the site (e.g. putting a greeting somewhere) and keep behavior as it exists in this branch. The main reason for this is that including the nick in the header introduces somewhat of a visual clutter as it is already relatively constrained vertically. Having the nick in the dropdown, while sounding good on paper, looks a little off and isn't super clear for the user what it does.