search

cthit / chalmersit-rails

Chalmers.it built with Rails
MIT License
4 stars 6 forks source link

Save cid after successful printer action #353

Closed Kalior closed 5 years ago

Kalior commented 6 years ago

Not sure if we should have a "remember me" box, but I don't feel like doing that. Fixes #352

Portals commented 6 years ago

We should have a 'Remember me' box imo, to give the user control of what data is being saved.

Dr-Horv commented 6 years ago

I guess this is saved in the browser? So It's actually on the user's computer rather then on our side. Giving the user full power to clear browserdata.

Kalior commented 6 years ago

Yeah, it's saved in LocalStorage. And if we want to be consistent with telling the user about when we save data on their computer, we should probably consider a checkbox for saving the latest/most often used printer, as well as the student-union-card number.

Portals commented 6 years ago

How about merging this, then open a issue regarding using remember me boxes whenever we save information in localstorage @Kalior?

Kalior commented 6 years ago

Sounds great to me!

Portals commented 6 years ago

Great, I am requesting reviews from people who I think could review this PR.