cthit / hubbIT-old

Former WhoIsInTheHub
https://hubbit.chalmers.it
MIT License
2 stars 9 forks source link

Fik it asset #179

Closed Gurrit closed 6 years ago

ghost commented 6 years ago

This changes the hookit banner as well as the fikit banner

ghost commented 6 years ago

Nevermind 😅 Just weird commits. Everything seems fine 👌

malmers commented 6 years ago

The indentation looks off

malmers commented 6 years ago

First off: I love seeing non-digIT folks contribute with code, that's awesome!

It's not my call to say whether this feature should be accepted or if it will just add bloat to hubbIT. I do however have some constructive feedback on how to make the code work. As I see it there are two issues with it right now:

The code should probably be written as:

tr#HookIT {
  background: image-url("wanted.png");
  th {
    color: #282828;
    font-family: "Rye";
    font-size: 1em;
  }
}

tr#FikIT {
  background: image-url("fikIT.png");
  th {
    color: white;
    font-size: 1em;
    text-shadow: -1px 0 black, 0 1px black, 1px 0 black, 0 -1px black;
  }
}
Portals commented 6 years ago

This should not be merged before Malms concerns are fixed!

Kaffe-work commented 6 years ago

Updated code in accordance to sedimentary suggestions.

Kaffe-work commented 6 years ago

When removing tabs, i checked the whole file again for indentation issues, and autoremoved tabs, turns out there are a few in the old code. I could push these changes as well.