Closed Gurrit closed 6 years ago
Nevermind 😅 Just weird commits. Everything seems fine 👌
The indentation looks off
First off: I love seeing non-digIT folks contribute with code, that's awesome!
It's not my call to say whether this feature should be accepted or if it will just add bloat to hubbIT. I do however have some constructive feedback on how to make the code work. As I see it there are two issues with it right now:
FikIT.png
in the scss but is saved as fikIT.png
tr#FikIT
is accidentally nested within tr#HookIT
The code should probably be written as:
tr#HookIT {
background: image-url("wanted.png");
th {
color: #282828;
font-family: "Rye";
font-size: 1em;
}
}
tr#FikIT {
background: image-url("fikIT.png");
th {
color: white;
font-size: 1em;
text-shadow: -1px 0 black, 0 1px black, 1px 0 black, 0 -1px black;
}
}
This should not be merged before Malms concerns are fixed!
Updated code in accordance to sedimentary suggestions.
When removing tabs, i checked the whole file again for indentation issues, and autoremoved tabs, turns out there are a few in the old code. I could push these changes as well.
This changes the hookit banner as well as the fikit banner