Closed nuest closed 10 months ago
AFAICT the failing tests are due to my changes for make pydantic 2 happy, so I'll revert those.
Tests work no on my fork, no idea why they do not show up here: https://github.com/nuest/zenodo-client/actions/runs/5892513675
@nuest any movement forward on this?
Hi! Working on this now...
Ups, did you just merge by accident?
Never mind, must have been a glitch in my local git client.
@nuest I did a bit of clean up - linting, adjusting code to reduce diff, removing some minor changes that make it hard to review.
I still need to figure out how to make the environment available for tests so github actions can use my api token
Merging #23 (99b720d) into main (5ee911e) will decrease coverage by
27.78%
. The diff coverage is15.09%
.
@@ Coverage Diff @@
## main #23 +/- ##
===========================================
- Coverage 55.96% 28.18% -27.78%
===========================================
Files 6 6
Lines 218 259 +41
Branches 38 46 +8
===========================================
- Hits 122 73 -49
- Misses 89 186 +97
+ Partials 7 0 -7
Files Changed | Coverage Δ | |
---|---|---|
src/zenodo_client/__init__.py | 100.00% <ø> (ø) |
|
src/zenodo_client/api.py | 22.02% <15.09%> (-44.91%) |
:arrow_down: |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@nuest I improved the way tox and GHA passes around configuration. Could you please in your fork of the repo add a secret ZENODO_SANDBOX_API_TOKEN
and put a key from zenodo's sandbox? If you aren't able to get one, I can email you mine.
This will allow the tests to run in full on CI
Hi cthoyt!
Sorry for my silence and thanks for your efforts - I have actually continued to work on things myself and now we have to diverged code bases... I will take a look at the token for the CI tomorrow, not sure how to continue with my other branch, see
I merged, think I captured all you changes appropriately, but I also made some fixes due to more extensive tests (e.g., fixing upload of files for not-yet-published depositions).
I'll ping you when I'm done with the merge, needs some manual fixes.
Tests don't run through on my fork, "Too many requests". Maybe there is something wrong with the token?
https://github.com/nuest/zenodo-client/actions/runs/6177578545/job/16768995002
Tests complete fine locally (with the same token).
I added some additional logging and error handling to the tests, now it's able to pick up when configuration isn't correctly configured (which seems to be the case at the moment)
@nuest can you please break this into two separate PRs:
publish=False
)update_metadata()
)The way I suggest doing this is just removing the update_metadata()
functionality from this PR and making a separate one later.
The reason I'm asking this is there are too many changes that are hard to understand and read in the diff
I can do that. Just let me know when you are done with your edits - thanks!
@nuest all done, it's in your court :)
:tennis: Thanks! I'll get to it as early as possible next week.
My approach would be to make new branches from main and transferring the changes manually there - the git history of this PR is beyond my skillset to "pick" from it.
Easier - branch off of this branch, delete the stuff you don't need
Replaced by #28 and #29
Closes #21