search

ctidigital / magento2-configurator

Magento 2 Configurator
https://ctidigital.github.io/magento2-configurator/
MIT License
167 stars 59 forks source link

Unit Tests run without proper configuration #65

Open bartoszherba opened 6 years ago

bartoszherba commented 6 years ago

Currently Travis run unit tests without pointing to configuration file (eg. dev/tests/unit/phpunit.xml.dist) which yields in errors with tests execution. Configuration includes bootstrap.php which is required to run tests properly. As a result tests that pass locally do no pass during CI process and so it is not possible to develop any future implementation which includes tests.

Another thing is that sniffers run through tests files but are not configured to do so (eg. it is required to use a lot of static method or to name long descriptive tests method). As a result every tests must include sniffers/phpmd ignore annotation.

chevli commented 6 years ago

Hi @bartoszherba,

Once Version 1 (for M2.1) has been released, we'll look to work on Version 2 (for M2.2) as PHPUnit has updated and the test classes will require to also be updated.

Feel free to make any relevant changes to get the sniffers working properly :smile:.

bartoszherba commented 6 years ago

@chevli Could you reference PHPUnit changes? I can't find anything in changelog for 2.2.x Thanks in advance.

chevli commented 6 years ago

Magento 2.1

https://github.com/magento/magento2/blob/2324274f8b66180b0e1fa7896c369c6a09cae5aa/composer.json#L70

Magento 2.2

https://github.com/magento/magento2/blob/dbcc3c4d57b1e5566cbda92533a03ef5f36d608e/composer.json#L76