Closed maxnoe closed 4 months ago
Thanks a lot for this PR @maxnoe
Thanks for the PR @maxnoe. One question, removing setup.py will affect the release of the package in Conda?
How do you build the conda packages?
The conda recipe should contain a line like this:
script: {{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv
and this will still work, since conda will call out to pip to install the wheel
@TjarkMiener @rcervinoucm Why is no CI running here?
I see CI jobs running in the other PR by Tjark #200
@rcervinoucm I think this shouldn't have been merged in this state... you should have clicked on the button to start the CI workflow to check if the CI passes.
Hi Max, I have tried and the CI passes with the change s(I am working in a new branch and everything is ok), but you are right, I should have done that before
The release.yml workflow needs to be fixed, it is still using old stuff related to the old version handling and calls setup.py directly instead of using python -m build
I am working on that in a new branch, I will let you know when it is finished
pyproject.toml
(e.g. missing packages declaration, wrong extension for README)