ctlearn-project / ctlearn

Deep Learning for IACT Event Reconstruction
BSD 3-Clause "New" or "Revised" License
52 stars 43 forks source link

Update build configuration, use setuptools_scm #199

Closed maxnoe closed 4 months ago

maxnoe commented 4 months ago
TjarkMiener commented 4 months ago

Thanks a lot for this PR @maxnoe

rcervinoucm commented 4 months ago

Thanks for the PR @maxnoe. One question, removing setup.py will affect the release of the package in Conda?

maxnoe commented 4 months ago

How do you build the conda packages?

The conda recipe should contain a line like this:

script: {{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv

and this will still work, since conda will call out to pip to install the wheel

maxnoe commented 4 months ago

@TjarkMiener @rcervinoucm Why is no CI running here?

I see CI jobs running in the other PR by Tjark #200

maxnoe commented 4 months ago

@rcervinoucm I think this shouldn't have been merged in this state... you should have clicked on the button to start the CI workflow to check if the CI passes.

rcervinoucm commented 4 months ago

Hi Max, I have tried and the CI passes with the change s(I am working in a new branch and everything is ok), but you are right, I should have done that before

maxnoe commented 4 months ago

The release.yml workflow needs to be fixed, it is still using old stuff related to the old version handling and calls setup.py directly instead of using python -m build

rcervinoucm commented 4 months ago

I am working on that in a new branch, I will let you know when it is finished