ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Join in progress checkbox issues #1269

Closed ctm closed 6 months ago

ctm commented 7 months ago

Fix so the checkbox that a player gets for an in process event has a useful tooltip and is only enabled when it can work.

This is a continuation of #1241, which I've closed out now that I have fixed the server to reject illegal requests to join. The things that need to be done are:

ctm commented 6 months ago

The code for what we currently do is in lobby::events::running::event_row::Props::disabled. I'm not sure we're yet watching enough messages to provide as much information as possible.

ctm commented 6 months ago

I'm deploying now, since all the changes I've made today are useful. I still think there are places where the tooltips can provide better information, but I've fixed the bugs I've been aware of and new ones I've found. I'll leave this open, but I'm removing the bug label..

ctm commented 6 months ago

I added some more info to the tooltip for a disabled join box due to there being no re-entries left. That rounds out my changes, so I'm deploying now.