ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Document pop-up enabling in Chrome and Safari #1299

Open ctm opened 6 months ago

ctm commented 6 months ago

Add documentation to the Players' Manual how to disable pop-up blockers on Chrome and Safari.

At least one case of lag between when mb2 tells the Lobby there's a new game and when the player gets a table window is due to the pop-up blocker on Chrome. Since Chrome and Safari are very popular (and Firefox has issues), it makes sense to add a quick explanation on how to do a site-specific override.

fladjoe74 commented 6 months ago

Please assign this issue to me and I will add this asap!

ctm commented 6 months ago

Thanks!

fladjoe74 commented 6 months ago

Hey @ctm I don't have access to the manual, so can you please copy and paste from this doc?

ctm commented 6 months ago

Thanks!

I see yours is a new GitHub account, and so I assume you're relatively new to GitHub.

This repository is the manual, so if you clone it, you can make a pull-request. This manual is written in MarkDown and is formatted with mdbook.

If the above is enough info for you to get your mods into the right format, tested locally by you and a pull-request created, great. If not, I'll go ahead and do it, but it probably won't be today.

ctm commented 5 months ago

I can get a list of who this is happening to and how many times via select player_id, nick, count(player_id) from lobby_requests join players on player_id = players.id where variant = 27 group by player_id, nick order by count(player_id) desc;.

The above shows 8 players who have been bitten by pop-up failure five or more times since I added instrumentation, two players bitten three times, four twice and eight just once.

I'll guess most of the people who have only been bitten a small number of times were only playing a small number of time and were only there for WYWAE, but there are some notable exceptions of regular players who only had trouble once or twice. I may send email and ask about that.