search

ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Inline styles should be removed #1325

Closed ctm closed 4 months ago

ctm commented 4 months ago

Switch all our inline style usage to CSS.

Most of our use of inline styles is due to me not knowing what I was doing when I started the web front end. I still suck at design, but I have a better understanding of how things can be done. Now that I've added a Content Security Policy (#1323 ), it would be nice to get rid of the 'unsafe-inline' override for style-src.

ctm commented 4 months ago

I'll probably just do the conversion a little at a time and deploy as I go so that if I make a mistake it'll be spotted sooner rather than later. I've already done that for the color on icons.

ctm commented 4 months ago

I wound up removing all of them this morning, only to find out that we can't get rid of unsafe-inline because UIKit uses it.

Oh well. We'll move away from UIKit at some point so perhaps I didn't just waste half a day.

Deploying now.