search

ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Nicknames that are actions #1364

Closed ctm closed 2 months ago

ctm commented 3 months ago

Disallow nicknames that are actions.

Currently we allow nicknames like "Call 100". We probably shouldn't. To be honest, I haven't thought much about it, except there's a place in our front end where we temporarily replace someone's nickname with their action and before we created the newtype Nick, they were both String. However, I don't want to hack in the action as a Nick, both because that would be bad, in general, and because it would then cause us trouble if we chose to disallow nicknames that are actions.

So, this issue is a low priority "think more about it", designed to keep the concern in my mind as I finish (#1342).

ctm commented 2 months ago

I don't think I need to do anything here, but if I change my mind, nick.rs already has hooks to allow me to do so cleanly.