search

ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Unify docker invocations #1388

Open ctm opened 2 months ago

ctm commented 2 months ago

Fix local_docker and revert_to_tag to share the docker code that sent_deploy uses.

I just cleaned up build_and_send, deploy and sent_deploy when I added timstamps back to the logs (#1387). They now have no duplicated commands between them. Instead they use scripts from helper. Logically, I should also do the same to local_docker and revert_to_tag, and probably rename revert_to_tag to revert and have it default to the second most recent tag, since that's the most common usage.

I rarely use local_docker, although if I make build set up local:latest automatically, perhaps I'll reach for it sooner. Similarly, if I make revert go back to the second most recently deployed version, I may save a few minutes next time I have a brown bag bug.

ctm commented 2 months ago

I didn't get to this today, which means that there's no reason to keep this at high priority since I can do it the next time I get interested in local_docker or revert.