search

ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Alt button issue #1398

Closed ctm closed 1 month ago

ctm commented 2 months ago

Investigate using alt-button, but no alt-button warning.

Specifically:

2024-04-29T00:05:00.756912692Z WARN  [mb2::table] using alt-button, but no alt-button

The timestamp should be enough to identify the hand. This is from yesterday's evening tournament: 5248. I was playing in it and don't recall seeing any glitch reported in the chat, although at one point I thought we might have had two double board hands in a row, although I was programming while playing and could have almost undoubtedly imagined it.

ctm commented 2 months ago

That time is before the first hand. Turns out, joining during that first break causes this error message. This is due to mb2 knowing that the alt-button is going to be used, but the alt-button isn't actually set up before the first hand starts.

The solution is to set up the alt-button the same time we note that we're going to use it, or to otherwise detect that it's OK to not have been set up yet and not complain. All else equal, I prefer the former, but I'll need to examine the code to be sure, and although I'm leaving this issue with high priority, it's not sufficiently important for me to look at it now.

ctm commented 1 month ago

Fixed. Deploying now.