The problem is LevelRounds::level_summary is not exhaustive and even starts out with a comment:
TODO: This is not the way to do it ...
UnifiedStakesSummary based levels are exhaustive, but they currently lack some of the finer points that LevelRounds::level_summary provides: (e.g., "High Card" or "Low Card" when all the stud games use one or the other for bring-in and warning people about Big Blind antes not counting toward the flop).
The solution is to teach UnifiedStakesSummary based levels the tricks that LevelRounds::level_summaryprovides and then to get rid of LevelRounds::level_summary. I don't, however, plan to make the time for that "soon", so for now I can just tighten the criteria that LevelRounds::level_summary uses to determine if it's doing the right thing. However, as long as that is ad-hoc, it's bound to cause trouble.
ctm
commented
1 month ago
Fix so wsop_2023_73_mixed_big_bet and wsop_2024_77_mixed_big_bet don't produce invalid structure templates.
The problem is
LevelRounds::level_summaryis not exhaustive and even starts out with a comment:UnifiedStakesSummarybased levels are exhaustive, but they currently lack some of the finer points thatLevelRounds::level_summaryprovides: (e.g., "High Card" or "Low Card" when all the stud games use one or the other for bring-in and warning people about Big Blind antes not counting toward the flop).The solution is to teach
UnifiedStakesSummarybased levels the tricks thatLevelRounds::level_summaryprovides and then to get rid ofLevelRounds::level_summary. I don't, however, plan to make the time for that "soon", so for now I can just tighten the criteria thatLevelRounds::level_summaryuses to determine if it's doing the right thing. However, as long as that is ad-hoc, it's bound to cause trouble.