search

ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Panic on post-tournament table window after laptop close #1454

Open ctm opened 3 days ago

ctm commented 3 days ago

Figure out what caused my table window to panic after yesterday's WSOPS tournament.

This morning, when I opened my laptop, the table that I had been playing on had died due to a panic and I foolishly reloaded the page before thinking to look at the JavaScript console. So, I don't know what happened there, but with luck it'll be reproducible.

After yesterday's game, I left the table window up and didn't do a deploy, because there were no updated crates. That's fairly rare and > 90% of the time I do a deploy shortly after the tournament finishes. Additionally, I closed my laptop because I didn't want to be tempted to check on WSER in the middle of the night. So, I'm hoping that I can reproduce this, in which case it'll be trivial to fix.

ctm commented 3 days ago

I was not able to reproduce this on my own this morning, but I plan on leaving my window open after I bust and then closing my laptop. I normally do a deploy after the evening game if any crates change, and I even said I'd do a deploy of my Ping fix (#1453), but if I remember, I'll not deploy this evening in hopes of reproducing this bug tomorrow morning.

ctm commented 2 days ago

This one is going to be a PITA to track down, however, I can change various code to not panic but to continue when surprising things happen. I can only do that safely if there's something in place that will prevent infinite (or exceedingly frequent) errors, because for all its warts a panic does prevent that.

So, once I have something in place that rate-limits warnings and errors, I may as well send that info to the server (#1455), then I can replace code that might panic with code that will attempt to report an error and continue, confident (or at least very hopeful) that a cascade of errors won't make things worse.