ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Add ability to redraw to n-seated final table #1469

Open ctm opened 1 month ago

ctm commented 1 month ago

Make it so a the final table can seat a different number of players than the other tables.

In theory, this is trivial, however, currently if we add a new field to TournamentStructure, it requires trivial changes throughout the structure files. Since the structure files shouldn't exist (because that info should come from the database), I've let this problem fester. It's now slightly worse than it used to be, because I used to be able to use a sed command to add the field, but now with all the macro invocations, I may have to add the field in a few places where sed can't do it for me.

So, I'm going to see how long it takes to add the field and get everything compiling again. If I can do that in under a half hour, I'll probably proceed to implement the functionality today, even though I still have a bunch of packing to do for BARGE.

ctm commented 1 month ago

I was FOS. It took two invocations of sed, one edit of a single macro and a hand-edit of wrgpt.rs.

ctm commented 1 month ago

So, I did the "obvious" work to support expanding the table size, but the graphical UI doesn't show the new seat. My guess is the graphical UI determines the number of seats from the structure in a way that doesn't take the new final_table_handed into account. This will be easy to find and fix, but we're pretty close to this evening's tournament.