ctm / mb2-doc

Mb2, poker software
https://devctm.com
7 stars 2 forks source link

Refreshing post-loss table window resulted in white screen #1480

Open ctm opened 2 months ago

ctm commented 2 months ago

Fix so after a player busts, the table window can be refreshed.

After this evening's game, I refreshed my table accidentally (I meant to refresh a different window) and got a white screen. There was nothing in the JavaScript console to suggest that anything had failed. Inspecting elements showed there was a notice (which wasn't displayed) which said "this table is no longer available". My guess is that the other player had already bust, but that the game hadn't completely shut down.

This may not be a regression. It may just be a race-condition nobody has hit (or at least reported).

ctm commented 2 months ago

FWIW, I refreshed again after writing up this issue and got the tournament summary info that one is supposed to get after a tournament has finished. Now that I've slept on it, I'm stripping regression, since I'm leaning on this being a race condition.

ctm commented 2 months ago

Nothing in the text logs:

ubuntu@ip-172-30-2-88:~$ sudo docker logs -t mb2 | egrep 'WARN|ERROR' | grep -v 'Illegal SNI hostname'
2024-08-02T02:07:46.566066198Z messages: []
2024-08-02T07:18:35.197227078Z WARN  [rustls::common_state] TLS alert warning received: AlertMessagePayload { level: Warning, description: CloseNotify }

I will look in the db logs, but there is likely to be little to no data to observe. We deliberately try to log very little about non-playing users, and log nothing for observers so that we can support 10,000 observers joining "at once" on our tiny servers (hmmm… now that I think about it, I should load-test to make sure that the additional text logging doesn't throttle us. I doubt it would, but only one way to find out #1481).

ctm commented 2 weeks ago

I wound up with a white table again post loss and I'm not even sure that I refreshed. I may have. FWIW, this was a two table tournament and it was down to the final table (6064). It may make sense to see which table I started at.

ctm commented 2 weeks ago

RIght now I can click on the 6064 link on the lobby and get a table that works fine, but once I refresh it, it goes white.

ctm commented 2 weeks ago

The tournament ended, but if I use the table link, I get a white screen instead of something telling me that the table is no longer in use.

ctm commented 2 weeks ago

This also happens with table 6063, but if I go to 6062, it says "table is no longer active" (like it should).