Allow Players to see structure

[ctm]

Add some sort of UI to display information about the structure.

This is one I've know about for a long time but never created an issue for. However, since it was explicitly requested, it now has an issue.

framistat: Cliff: It would be useful to be able to see the game setup after the tournament has started, both for spectators, and for players (how long is the break, when is the break, what is the next game, ...?).

I don't see doing this before I do Ring Games (#88), because tournaments are currently playable (although far from optimal), but ring games aren't playable at all and I'd like to have them both for business reasons and for FARGO.

[ctm]

I just bumped this to high priority and added the chore tag, because if I am willing to do a crappy job on the UI, it is more of a chore than a feature, but at least it will allow people to know what they're choosing to set up or joining.

The one thing that kind of complicates this is that logically I'd like the url to include the id number of the structure coming from the database, but currently structures don't come out of the database; they're fetched from a HashMap using their "short_name". For expediency, we can use a route that uses the short-name for now and worry about backpatching the id in later.

[ctm]

I created a structure-439 branch and added a StructureId enum that can either take a string or a number and added a route for /structure/tournament/:structure_id.

However, the structures are known by the server, not the client, so one way or the other we need to make a request from the client to the server for the info.

Up until now, all requests have been made through a Web Socket, but I think this (and other requests, like hand histories) should be done through an API, which requires some new boilerplate (e.g., a new /api route for actix-web and the use of fetch and futures within the client). None of that is hard, per-se, but it does mean I need to make some choices that I hadn't anticipated making and it means I'm not even going to have a poor proof-of-concept ready for this evening's game.

[ctm]

I made a bunch of choices and now have both an API end-point and a UI end-point for tournament structures, with the UI calling the API. I don't yet have HTML in the UI, nor do I have a way for a new window with the structure to be created, but the former is just grunt work and the latter is trivial if I don't send the lobby session id.

Since all structures are currently public, there's no need to pass the lobby session id. However, if we want to do so, I think it's just a matter of having the structure window check to see if it has a parent. If so, wait for the message that will have the session id and if not, consider itself anonymous.

[ctm]

I've done the grunt work for many of the structure fields, but dealing with level names is a PITA, so right now the end of the rebuy, re-entry and lammer levels aren't generated. An even bigger PITA are rounds, and I didn't get to those, either. The page is also unstyled, which makes it even more garish than normal (yipes!).

However, event creation, upcoming events and running events all have circle-i small icons that can be clicked to get a link to the structure sheet. This is all in structure-439. I'm not deploying today, but I'll probably deploy tomorrow.

[ctm]

Here's what I'd like to get done before deploying today:

• [x] Disclaimer that this is a structure template, with true structure sheets coming later in the month
  • [x] Durations are in multiples of the duration of the first level
  • [x] Missing: Buy-in, Bounties, Comment, Starting Criteria, Seconds to Act, Calling Time Criteria, Synchronized Breaks, Late Registration
• [x] Level Duration Summary
  • [x] All one duration
  • [x] Mix e.g., wsop_2024_10_omaha_8_championship
• [x] List the various levels, by name, for
  • [x] Rebuy
  • [x] Re-entry
  • [x] Lammer Redemption
  • [x] Add-ons (too broken to spend time on now)
• [x] Game Summary
  • [x] All One Game (e.g., wsop_2024_29_deuce_to_seven_3d_championship)
  • [x] All One Mix (e.g., wsop_2024_96_horse)
  • [x] Same number of hands for all in mix, e.g., wsop-2022-eight-game-mix
  • [x] Different number of hands, e.g. wsop_2024_41_nlhe_plo_with_double_board_bomb_pot
    • [x] description currently doesn't list that it's
      • [x] Double Board
      • [x] Bomb Pot
  • [x] More than one game or mix (this list is not even close to being complete)
  • [x] cart_horse
  • [x] embargo_2024_toc
  • [x] o8_he_pair_fargo_2020
  • [x] so_mixed_hold_em
  • [x] so_mixed_hold_em_barge_2021
  • [x] toc
  • [x] toc_barge_2020
  • [x] toc_barge_2021
  • [x] toc_barge_2022
  • [x] wywab_2023_toc
  • [x] monte
  • [x] Dealer's Choice (this list is complete)
  • [x] wsop_2023_05_dealers_choice
  • [x] wsop_2023_10_dealers_choice_championship
  • [x] wsop_2024_07_dealers_choice
  • [x] wsop_2024_13_dealers_choice_championship
  • [x] "Limit" has actual stakes in the description, e.g., "100 200 Hold'em" instead of "Limit Hold'em"
• [x] Levels
  • [x] Fixed Bet Blinds (Level, Blinds, Limits) e.g., wsop_2024_10_omaha_8_championship
  • [x] Big Bet with Big Blind Ante (Level, BB Ante, Blinds) e.g., wsop_2024_98_closer_nlhe
  • [x] Pot Limit with Big Blind Ante (counting as pot after the flop) (Level, Blinds, Call or Make It, Ante) e.g., wsop_2024_08_plo
  • [x] Fixed Stud (Level, Ante, Bring-In, Completion, Limits) e.g., wsop_2024_40_razz
  • [x] All limit, mix of stud and non-stud, with antes only in stud
  • [x] Include disclaimer that each game either uses blinds or ante, none use both
  • [x] With single stakes, e.g., sam-6
  • [x] With unifiable stakes, e.g., wsop-2024-61-mixed-o8-seven8
  • [x] Mix with just one element in the Vec<Stakes> but that includes big-bet and fixed, e.g. bourbon
  • [x] Anything Else (e.g., a generic, potentially super-zilla double-butt ugly) incomplete list:
  • [x] wsop_2024_45_horse_championship
  • [x] wsop_2024_77_mixed_big_bet
  • [x] wsop_2024_91_horse
  • [x] wsop_2024_96_horse
  • [x] barge_eight_game_mix
  • [x] boom
  • [x] eight_game_mix_20k
  • [x] wsop_2022_eight_game_mix
  • [x] wsop_2022_nine_game_mix
  • [x] wsop_2022_poker_players_championship
  • [x] wsop_2023_05_dealers_choice
  • [x] wsop_2023_10_dealers_choice_championship
  • [x] wsop_2023_27_eight_game
  • [x] wsop_2023_36_nine_game
  • [x] wsop_2023_43_poker_players_championship
  • [x] wsop_2023_45_mixed_omaha_hi_low
  • [x] wsop_2023_73_mixed_big_bet
  • [x] wsop_2023_78x_hosdarss_championship
  • [x] wsop_2024_07_dealers_choice
  • [x] wsop_2024_13_dealers_choice_championship
  • [x] wsop_2024_41_nlhe_plo_with_double_board_bomb_pot
  • [x] wsop_2024_43_mixed_omaha_hi_low
  • [x] wsop_2024_53_nine_game
  • [x] wsop_2024_77_mixed_big_bet
  • [x] wsop_2024_83_eight_game
  • [x] wsop_2024_88_eight_game_mix_championship
• [x] Custom Level names (e.g. 1A, 1B) e.g., wywab_2023_toc
• [x] Styling
  • [x] Make disclaimer less prominent (put it in Player's Manual and link to it)
  • [x] Display mixes as table or list, rather than elements separated with ", " and " and "

[ctm]

I'm going to move my disclaimer verbiage from the structure template to the Players' Manual and then link to it, the I'll deploy. The styling is essentially non-existent and it's not smart enough to recognize repeating games, like we get in TOC and MONTE and it still doesn't dump the levels at all, but it does allow us to peer inside a structure template now and even allowed me to find a bug in my CART -> HORSE structure.

[ctm]

I'm deploying now, with a version that completely omits level info. There's enough time that I could probably get some of the easier level dumps in place before another deploy, but I'm going to take a break of an undetermined length, first.

[ctm]

We played with the new code yesterday, and I'm glad I pushed it out in time for us to do it, because the name of the game that is announced to the players is currently much longer: "No-Limit Double Board Bomb Pot Texas Hold’em (High only)" vs. "No-Limit Texas Hold’em (High only)", but when two boards are dealt it's kind of obvious that we're playing double board.

So, that brings up two issues:

• The in-game description is too long
• There are several options that are not currently listed in the structure templates

Looking through the GameKeeper code, it looks like there's also:

• Whether or not check-raising is allowed
• Whether or not limping is allowed
• Whether the "Sevens Rule" is enforced (no shit!)
• Whether we're playing "Jam or Fold"

And that also brings up the fact that a game doesn't actually have an ante, unless both Options allows the use of an ante and there is an Ante in the Stakes.

So, I think having a single all-details-included long description of the game that is to be played is undesirable. Instead we'll need to check for consistency throughout the structure and just say something like "In this event, the Sevens Rule in California Lowball is (or is not) enforced", assuming it is indeed the same throughout. However, when people are allowed to build their own structures, we'll then either need to make the builder enforce consistency or be able to somehow identify mixes of obscure things like the Sevens Rule (e.g., on Levels 1, 8 and 10, the Sevens Rule is enforced; everywhere else, it's not"). And of course the status of the Sevens Rule should never be mentioned if there are no games to which it could apply (and the only game to which it can apply is California Lowball).

Oy!

[ctm]

I've added level info for the common simple levels. I am probably going to take a break from working on this issue for a while. It was meant to be a one-day hack-and-slash feature so the winner would have more insight as to what is available. That functionality is now mostly present (albeit ugly), but it took way more than a day. OTOH, there are some things I went out of my way to do "right" and although I've cut some corners, I'm pretty happy with my growth as a Rust programmer.

[ctm]

As of my deploy yesterday, there are only 22 structures (out of 285) that mb2 can't produce levels for, and I've updated my checkboxes above to list them all. The only non-WSOP-Style ones are:

• boom
• barge_eight_game_mix
• eight_game_mix_20k

and both eight game mixes are the same other than the starting chips. I think if I add enough smarts for mb2 to do the levels for any of the WSOP-Style Dealer's Choice structures, we get all the other ones, for free and I already wrote down notes as to how I think I can do that. Unfortunately, I'm not programming for a little while as I concentrate on the business side of things.

[ctm]

We're down from 22 that we can't produce levels for to only four, and there those four are, for all practical purposes, just two different structures, each having two exceedingly similar instances.

Specifically, barge_eight_game_mix and eight_game_mix_20k are essentially the same, and both have two different fixed-limit stakes. The "normal" ones and the lowball ones.

wsop_2023_73_mixed_big_bet and wsop_2024_77_mixed_big_bet are essentially the same, and they both have two different no-limit stakes. The "normal" ones and the ones for No-limit Five Card Draw and No-Limit Deuce-to-Seven.

My guess is I'll just leave those "four" unhandled for a while, although currently the mixed big bet templates get incorrect levels (#1407) and so I need to stop that from happening, because no-information is better than incorrect-information.

[ctm]

Although there's still more to do, it can be done later, so I'm stripping the high priority label.

[ctm]

I added support for the two eight_game_mix and two mixed_big_bet structures. The output is super ugly, but it's better than nothing. In fact, it allowed me to see subtle problems with those structures, which I cleaned up.

Deploying now.

[ctm]

After sleeping on it, I believe I've done enough to close this issue, since all the information about a tournament is now available before and during the tournament. I have, however, created a couple new issues in this area (#1439 and #1440). Hail Hydra!