Closed boulund closed 3 years ago
Replace mash screen with sendsketch.sh - Sounds good.
Replace BBDuk with fastp. - I never used fastp but your arguments sounds reasonable -> approved :)
License issue and SignalP-dependency of Prokka. - I think this sounds reasonable but have no experience in making Docker container myself so I don't know how much work this would be?
Update all main tools to the most recent versions. - No brainer
Assembly assessment tools I think could be nice. Bacteria are not mentioned at all in BUSCO, it seems to describe application to larger genomes. So we should just double check that this is proper, or look into alternatives.
I think we should stick to these updates first and then add more things if/when there is time + an actual, concrete and general (in most projects) need for it.
@huyue87 and I brainstormed a bit about potential improvements to BACTpipe in version 3. We considered rewriting BACTpipe to something like the following workflow graph.
In this suggestion we use:
The suggested outputs will be:
Open questions
stats.sh
, but maybe we want to run Quast? We also previously discussed BUSCO. Another alternative could be e.g. CheckM, but I have never used that for isolate assemblies.@thorellk @huyue87 and I recently had a meeting to plan for the work ahead. We decided to also add ResFinder to the suite of tools to be run. BACTpipe is really becoming a CGE workflow :laughing: ...
We also decided to split up development efforts into version 3 and 4. Version 3 will focus on getting the basic short read workflow in place, and version 4 will add support for long reads. We committed a few draft workflow graphs to docs/source/img
on the develop
branch.
Hi! I found your pipeline while looking for some program that would screen assembled contigs for contamination in my microbial pipeline. I am glad that my pipeline is looking roughly similar to yours. I can recommend you abricate from tseemann for virulence and resistance finding. It implements several databases, it is easy to run, runs fast, and in silico results are in agreement with our wet lab results.
Hi @valzip ! Thanks for sharing! We also love pretty much everything Torsten does :D. We've actually discussed abricate previously, and it's not at all impossible that we might decide to use abricate instead in the end.
I think it is time to review the BACTpipe workflow and update/replace some parts.
Looking for input @huyue87 and @thorellk!
I have the following ideas:
mash screen
(#54). It was originally intended as a screening step to not unnecessarily assemble potentially contaminated isolates, but in reality we assemble all samples anyway so this just wastes resources (time, CPU, memory) when it can easily be replaced by asendsketch.sh
run on the assembled contigs. If the sample is contaminated we will still see it in the assembled contigs.Please share any comments or ideas on how we can streamline and improve BACTpipe. I remember we've also talked about potentially including some MLST tools, genome assembly assessment tools (e.g. #103), or phage finding tools (#96).