search

ctn-archive / nengo_theano

ABANDONED; see https://github.com/nengo/nengo instead
MIT License
3 stars 3 forks source link

moved connection logic into connection Ops #35

Closed jaberg closed 11 years ago

jaberg commented 11 years ago

If we move connection logic into their own Ops, then high level graph manipulation becomes a lot easier. This PR doesn't have that manipulation code, but it moves some of the theano reshaping & stacking etc. from network.py into the body of new Ops in connection.py

studywolf commented 11 years ago

what's going on in the if statement on lines 53-54 of connection.py?

jaberg commented 11 years ago

cut and paste error.

What tests should I run as a basic smoke test of these changes?

On Wed, May 1, 2013 at 12:04 PM, studywolf notifications@github.com wrote:

what's going on in the if statement on lines 53-54 of connection.py?

— Reply to this email directly or view it on GitHubhttps://github.com/ctn-waterloo/nengo_theano/pull/35#issuecomment-17289083 .

studywolf commented 11 years ago

just a basic one that uses a slew of things would be the test_basal_ganglia.py file! should look like this at the end bg

studywolf commented 11 years ago

also I ran a couple of them myself and I think they're good to merge in, if there's nothing else you wanted to do on this one I can go ahead and do it

tbekolay commented 11 years ago

Since this is a pull request from a remote branch, it might be a bit more complicated. If it is, I can do the merge if it's ready.

studywolf commented 11 years ago

Actually it's pretty OK! There's that link next to the green button that walked me through getting it

tbekolay commented 11 years ago

Cool, yeah, I was just looking at that too! Handy.

studywolf commented 11 years ago

merged!

tbekolay commented 11 years ago

I think the second commit (https://github.com/jaberg/nengo_theano/commit/a3e09a4381450642d23cc723859215ead598770f) was missed.

studywolf commented 11 years ago

second attempt!

tbekolay commented 11 years ago

:+1: