ctn-archive / nengo_theano

ABANDONED; see https://github.com/nengo/nengo instead
MIT License
3 stars 3 forks source link

put j_bias and alpha in LIFNeuron #38

Closed jaberg closed 11 years ago

jaberg commented 11 years ago

j_bias and alpha seem to me like natural attributes of the neuron, which should be used in LIFNeuron's update function. LIFNeuron already implements the logic for allocating these variables. What's the rationale for making them part of the enclosing ensemble, and accessing them from EnsembleOrigin too?

studywolf commented 11 years ago

So I've tried putting them in both places, but I think it does end up making more sense not having them in the neuron, but in the ensemble, because they're NEF dealies. In the NEF, the activity to the neuron is calculated as

G[alpha * enc * X + j_bias],

where then G is the neuron dynamics. So while they're calculated once and then assigned to specific neurons, every neuron model will still have these parameters, and if we get terry's generic calculation of the gain and bias then we can find them independent of the neuron model.

tl;dr they're NEF things! independent of the neuron model. should be in ensemble, not neuron models

jaberg commented 11 years ago

I'm convinced, thanks for spelling it out.

On Wed, May 1, 2013 at 2:23 PM, studywolf notifications@github.com wrote:

So I've tried putting them in both places, but I think it does end up making more sense not having them in the neuron, but in the ensemble, because they're NEF dealies. In the NEF, the activity to the neuron is calculated as

G[alpha * enc * X + j_bias],

where then G is the neuron dynamics. So while they're calculated once and then assigned to specific neurons, every neuron model will still have these parameters, and if we get terry's generic calculation of the gain and bias then we can find them independent of the neuron model.

tl;dr they're NEF things! independent of the neuron model. should be in ensemble, not neuron models

— Reply to this email directly or view it on GitHubhttps://github.com/ctn-waterloo/nengo_theano/issues/38#issuecomment-17297277 .