search

ctnadovich / randowizard

Randonneuring.org web application
GNU Affero General Public License v3.0
0 stars 1 forks source link

Manual Rider Entry -- no RUSA check #17

Closed ctnadovich closed 7 months ago

ctnadovich commented 7 months ago

It doesn't appear that the full "member at event end" test is performed on riders added to the roster manually.

ctnadovich commented 7 months ago

I didn't find an easy way to add this membership check to the manual rider add. Since the rider_id field is a relational join, it's unclear how to persuade grocerycrud to select only valid members. Nor is it obvious how to use SetRules here. I suppose some combination of callbacks could do it, but it seemed to be a lot of work.

As a workaround I added a manual membership check function that (presumably) you'd manually run after manually adding riders that you hadn't manually vetted some other way.

Not a perfect solution, but maybe the best option. I mean, it's POSSIBLE that an RBA might want to add a rider to the roster without a RUSA check for some reason. Allowing manual entry to bypass checking would allow this.

I'm going to close this issue till somebody makes a case that automatic vetting of manual rider entries is a necessary feature.