ctnadovich / randowizard

Randonneuring.org web application
GNU Affero General Public License v3.0
0 stars 1 forks source link

Sometimes control open/close times are in UTC #37

Open smkeesle opened 3 months ago

smkeesle commented 3 months ago

The open and closing times on the generated cue sheet list times in UTC. While accurate, it requires tired rando brains to do simple arithmetic. This could result in increased anxiety, shortness of breath, elevated blood pressure, and even death as the exasperated attempt to sprint to finish before a miscalculated closing time.

Given a RWGPS route in a region with a designated TZ, and no tzname specified on controls, the start and end time of each control will display the times in the region's TZ on the cue sheet.

Given a RWGPS route in a region with a designated TZ, and a different tzname specified on a control (maybe the route crosses into another TZ?), the start and end time of of each control will be displayed in both the REGION TZ AND the TZ of that control on the cue sheet. e.g. Open: Jun-08 11:37 EDT / 08:00 CDT Close: Jun-08 14:56 EDT / 15:56 CDT

IDK if that should be the case for all of the controls...or just those controls out of the region's TZ. What of half of the route was in one TZ, and half another? and half the riders came from each with windup watches that were set for their home TZ? This could get nuts!

ctnadovich commented 3 months ago

The open and close times on the generated cue sheet aren't in UTC. If that happens sometimes, it would be a bug needing to be fixed. Can you point me at an event where this is the case? The times should be in the event time zone, which is usually the region time zone, unless overridden. Seriously, I believe timezone support is correct on both the cuesheets and the brevet cards. If it isn't, please show me where it isn't.

smkeesle commented 3 months ago

https://randonneuring.org/assets/local/cuesheets/932007-8-CueSheetV9-P.pdf

smkeesle commented 3 months ago

I re-fetched the route and republished the event. The times are now in EDT. Magic!

ctnadovich commented 3 months ago

It would be great if we could figure out how to reproduce this. It could be a bug that needs fixing. Generally speaking, if everything is working as designed, with no overrides, then all the public web pages and all the printable documents should be in the region TZ. Never in UTC. So if they ARE in UTC, it's a problem.

I'm going to leave this issue open for the moment. We can all keep an eye open for it. Maybe we can figure out how it can happen. Then I can fix it.