search

ctowery / tesla_website2019_dev

MIT License
0 stars 7 forks source link

Footer and header span width of page #3

Closed mameehan5 closed 5 years ago

ctowery commented 5 years ago

Mike, do you mean the black background of the footer/header, or the margins of the icons and text? On my computer the black spans the screen and the icons/text are aligned with the margins for each homepage widget.

mameehan5 commented 5 years ago

Does the black footer background span the page? The header I made it look like it by specifying that background black. We must need to just make the homepage span the full screen and add a margin around it (for readability). Then the black footer will span the width.

ctowery commented 5 years ago

Oh yeah, nm, I don't know why I thought the footer's black background was spanning the page. I think I can fix that real quick

ctowery commented 5 years ago

Oh snap, the webpage has a white background on Safari and a dark gray background on Chrome. Sigh

ctowery commented 5 years ago

Also the sticky-topclass works in Chrome but not Safari, BOOOO!

mameehan5 commented 5 years ago

Oh goodness. I did not think that we would be having issues that spanned different browsers. Not a fan of that.

ctowery commented 5 years ago

Ok, I apparently screwed up associating a particular commit with fixing this issue, so just know there is a commit that resolves the footer problem by creating a new top-level GoHTML script, /layouts/_default/baseof.html, which overrides /themes/academic/layouts/_default/baseof.html