Is beam search working fine?

ctr4si / A-Hierarchical-Latent-Structure-for-Variational-Conversation-Modeling

PyTorch Implementation of "A Hierarchical Latent Structure for Variational Conversation Modeling" (NAACL 2018 Oral)

MIT License

174 stars 45 forks source link

Is beam search working fine? #3

Open shubhamagarwal92 opened 6 years ago

shubhamagarwal92 commented 6 years ago

Is your beam search bug free?

I tried to use your decoder in a seq2seq model and getting some weird results when beam width>1. (BLEU falls from 40 to 4).

You also don't report any results corresponding to beam search in the paper.

Thus, want to confirm before using the code.

AotY commented 5 years ago

I got the same problem.

sb1992 commented 5 years ago

I am also having the same problem. Did you manage to implement beam search correctly?

manzar96 commented 4 years ago

Did you solve the bug on beam search?

shubhamagarwal92 commented 4 years ago

@manzar96 Sorry I am not working on this anymore. You can have a look at the transformers or allennlp repo and integrate their beam search method with this repo.