search

ctrachte / Datepicker.js

Simple standalone date picker with only html, css and moment.js
https://www.npmjs.com/package/moment-datepicker-js
MIT License
4 stars 7 forks source link

some refactoring - added functions for time picker #141

Closed mr-jac closed 3 years ago

mr-jac commented 3 years ago

I added some functions for some of the more repetitive parts. This is by no means all the refactoring we could possibly do, but a decent start. I think next I'll do that CSS work, and then maybe do some more of this, if it's all good so far.

mr-jac commented 3 years ago

Ok, I made a new PR. Let me know if it's ok.

ctrachte commented 3 years ago

Merged! Great work, keep it up!

Caleb

From: Jacob DeBoer @.> Sent: Tuesday, October 12, 2021 11:49 AM To: ctrachte/Datepicker.js @.> Cc: Caleb Trachte @.>; Comment @.> Subject: Re: [ctrachte/Datepicker.js] some refactoring - added functions for time picker (#141)

Ok, I made a new PR. Let me know if it's ok.

- You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fctrachte%2FDatepicker.js%2Fpull%2F141%23issuecomment-941189219&data=04%7C01%7C%7Cc6a5bdabaac04eab5c8308d98da0218d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637696541154602501%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=I8r47HMxgIFPZ6DpaGEQaUqIQMtulROjeUi43fYjVds%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH4BGME3LI72LFGU5CMIVP3UGRRGFANCNFSM5F2XMYYQ&data=04%7C01%7C%7Cc6a5bdabaac04eab5c8308d98da0218d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637696541154607484%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aGcWD%2B2Ilcr8QHtq16ZmTl%2Bfzsr7tf%2F2NU%2FwRTsLxeY%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cc6a5bdabaac04eab5c8308d98da0218d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637696541154612464%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=d8fj3YU2YN6bjJRp%2FvFd3Mq7nsphfmRlOrzK6edYFfI%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Cc6a5bdabaac04eab5c8308d98da0218d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637696541154617445%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=jks8hgKk59YT%2BPwR8tQZ2JFDl4zjKtundXj%2BuZHqRDc%3D&reserved=0.