ctrachte / Datepicker.js

Simple standalone date picker with only html, css and moment.js
https://www.npmjs.com/package/moment-datepicker-js
MIT License
4 stars 7 forks source link

Calendar Placement, Responsiveness #146

Closed ctrachte closed 2 years ago

ctrachte commented 2 years ago

Currently, when using the Datepicker on smaller devices, the calendar will not be entirely visible on the screen because of absolute placement.

We need to rework the calendar placement so that:

Smaller devices don't bother with datepicker.calendarPlacement() but rather use straight css, and breakpoints

himansh-gjr commented 2 years ago

Hey @ctrachte I will love to work on this, I followed the instruction from here to setup the project locally by using git clone but getting a blank page when opening the Datepicker.html in google chrome

Screenshot 2021-10-18 at 9 42 19 PM

.

I am new to open source need some help in getting started and setting up the project.

ctrachte commented 2 years ago

That is interesting. I have the master branch open right now in Chrome and I do not have that error. Do you see any console errors in your dev tools when you right click > inspect?

ctrachte commented 2 years ago

I would suggest getting a fresh copy, then ensuring you are checked out onto the main branch, then double check the references in your Datepicker.html file. You may need to remove the import and export lines in Datepicker.html and Datepicker.js respectively. Then ensure the Datepicker.js file is referenced correctly in the <script> tags of Datepicker.html

himansh-gjr commented 2 years ago

Thanks ! it's working now, issue was the Githubissues.

  • Githubissues is a development platform for aggregating issues.