search

ctrachte / SimpliFly

A single-page progressive web app to show flights for a certain origin, destination, and their prices
2 stars 1 forks source link

Custom Weather Icons #17

Open ctrachte opened 3 years ago

ctrachte commented 3 years ago

Weather.gov's API does not always return an image for the weather condition.

We need to phase this param out of the Simplifly app, and reference our own images for weather conditions from the /assets folder.

MrRedBeard commented 3 years ago

Depending on what you & @andrewdeclue want done with the NOAA icons here are some free font based icons https://www.iconfinder.com/iconsets/weather-color-2

MrRedBeard commented 3 years ago

Here is a full list of NOAA weather conditions and the icons they use https://w1.weather.gov/xml/current_obs/weather.php

MrRedBeard commented 3 years ago

Found a observation that did not have an icon "light rain,mist". It's coming back as null but there is an icon https://w1.weather.gov/images/fcicons/ra1.jpg but I think the API is returning https://www.weather.gov/images/fcicons/ra1.jpg

ctrachte commented 3 years ago

Thanks for leaving these comments to track this issue @MrRedBeard

MrRedBeard commented 3 years ago

Same for "unknown precip,mist". I have no idea why the current observation is unknown, even says it on the weather page for that location. https://forecast.weather.gov/MapClick.php?lat=47.41515000000004&lon=-120.29472999999996#.X_NyXdhKi70

MrRedBeard commented 3 years ago

Also need to account for "NA" https://forecast.weather.gov/MapClick.php?lat=40.14390000000003&lon=-120.12976999999995#.X_OCethKi70

ctrachte commented 3 years ago

@andrewdeclue tagging you so you can checkup on @MrRedBeard 's comments

MrRedBeard commented 3 years ago

@andrewdeclue yell at me if you have any questions about NOAA specifically

andrewdeclue commented 3 years ago

I ended up doing some CSS and Bootstrap to improve the look of the current icons being pulled. Tab was looking at the error handling and I talked to him about what I was doing with it... but decided to go ahead and commit the small change rather than something that I think would conflict. I'll swing back around to the missing icons and potentially complete icon replacement.