Make `with_comment_column` work with `Annotate.set_defaults`

ctran / annotate_models

Annotate Rails classes with schema and routes info

Other

4.42k stars 620 forks source link

Make `with_comment_column` work with `Annotate.set_defaults` #990

Closed Adeynack closed 12 months ago

Adeynack commented 1 year ago

Describe your problem here.

Commands

$ rake annotate_models

Acceptance Criteria

"with_comment_column" => "false" appears after "with_comment" => "false" when calling rails generate annotate:install.
its setting is read when annotating (right now, setting it to true does not activate the switch and comment column is not rendered).

Related Issues

This was an oversight when implementing #988.

Adeynack commented 1 year ago

@ctran : You can assign me on this. I will work to fix it.

ctran commented 1 year ago

Thanks

sureshc commented 1 year ago

Any progress on this? We have a few long table column comments and having this option work with .set_defaults would make the annotations more readable. We can't really turn on with_comment because of the formatting.

Adeynack commented 1 year ago

To be 💯 honest, that slipped my mind completely. But I'll resume my effort here, especially if it can make other's life easier! Thanks for the reminder ;-)

sureshc commented 1 year ago

To be 💯 honest, that slipped my mind completely. But I'll resume my effort here, especially if it can make other's life easier! Thanks for the reminder ;-)

Thank you so much. We very much appreciate this gem.

Adeynack commented 1 year ago

@sureshc @ctran : If I am not mistaken, #999 should do the trick :-)

Adeynack commented 10 months ago

@ctran : When can we expect a release with this feature added? 😊