search

ctran / annotate_models

Annotate Rails classes with schema and routes info
Other
4.41k stars 598 forks source link

Make `with_comment_column` work with `Annotate.set_defaults` #999

Closed Adeynack closed 10 months ago

Adeynack commented 11 months ago

Fixes #990

sureshc commented 11 months ago

Thank you! I'm not familiar with this codebase. Are there any tests that need to be updated to validate this change?

Adeynack commented 11 months ago

@sureshc : The only test I found that seems to concern .set_defaults are strangely specific to ONE configuration key, so I decided to not touch it. @ctran can maybe point me at where it would be decent to test this thing. I am also very uncomfortable in submitting modifications without any kind of automated testing proving its worth.

ctran commented 11 months ago

@sureshc : The only test I found that seems to concern .set_defaults are strangely specific to ONE configuration key, so I decided to not touch it. @ctran can maybe point me at where it would be decent to test this thing. I am also very uncomfortable in submitting modifications without any kind of automated testing proving its worth.

Maybe add a new test in https://github.com/ctran/annotate_models/blob/master/spec/lib/tasks/annotate_models_migrate_spec.rb?

Adeynack commented 11 months ago

@ctran : I added a brand new spec file for it, since I judged it was a separate concern than what's in annotate_models_migrate_spec. But thanks a lot for this hint, it pushed me directly in the right direction! 🤩

Adeynack commented 10 months ago

@sureshc @ctran : Code is complete & tests were written. Please review 😺