search

ctreffe / alfred

Alfred - A library for rapid experiment development
MIT License
10 stars 1 forks source link

Inconsistent method naming for appending operations #14

Closed ctreffe closed 5 years ago

ctreffe commented 5 years ago

Appending an item to a section or to the PageController is done with a method named append_item and appending an Element to a Page is achieved by calling add_element.

While I think it is important to differentiate between appending sections or pages to pagegroups and appending elements to composite pages, we should not use both terms add and append. Since append is what we actually do, we should rename add_element to append_element.

jobrachem commented 5 years ago

The methods are now called append(). The old methods still work and call append() now. When one of the old methods is used, a warning is printed and logged.