search

ctreminiom / go-atlassian

✨ Golang Client Library for Atlassian Cloud.
https://docs.go-atlassian.io
MIT License
131 stars 34 forks source link

Add confluence v2 get children #208

Closed squatched closed 8 months ago

squatched commented 1 year ago

Fixes #207 (GET Get child pages).

Sorry if this doesn't fit your organizational scheme or naming pattern. I'm still trying to build a reasonable mental model of how your package is laid out in comparison to the reference docs...

codecov[bot] commented 1 year ago

Codecov Report

Merging #208 (c4ead4e) into main (97c7c52) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   89.25%   89.27%   +0.01%     
==========================================
  Files         148      148              
  Lines       11626    11644      +18     
==========================================
+ Hits        10377    10395      +18     
  Misses        632      632              
  Partials      617      617
Files Changed Coverage Δ
confluence/internal/page_impl.go 92.20% <100.00%> (+1.03%) :arrow_up:
squatched commented 1 year ago

Documentation PR: https://github.com/ctreminiom/go-atlassian-docs/pull/1

ctreminiom commented 1 year ago

closing pr due inactivity

squatched commented 1 year ago

I'm sorry but what activity was needed? I don't see any feedback here and I've been using a custom build of go-atlassian using this PR for weeks now without issue. Is there something that needs to change?

squatched commented 9 months ago

What needs to be done to get this merged? Anything I can help with?