search

ctreminiom / go-atlassian

✨ Golang Client Library for Atlassian Cloud.
https://docs.go-atlassian.io
MIT License
131 stars 34 forks source link

:green_heart: Upgraded the golang version to test/lint #294

Closed ctreminiom closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.07%. Comparing base (06e675c) to head (721e383). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #294 +/- ## ========================================== + Coverage 88.89% 89.07% +0.18% ========================================== Files 154 156 +2 Lines 12094 12152 +58 ========================================== + Hits 10751 10825 +74 + Misses 701 679 -22 - Partials 642 648 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Fank commented 3 months ago

I quickly checked the 1.21 tests why they are failing and retried them, the code looks good to me. I will check later with 1.21 why they are failing, maybe i can reproduce it.

ctreminiom commented 3 months ago

I quickly checked the 1.21 tests why they are failing and retried them, the code looks good to me. I will check later with 1.21 why they are failing, maybe i can reproduce it.

Yeah, the root cause it's because I used an old version of the linter to support the versions 1.17, 1.18, 1.19