search

ctrf-io / github-test-reporter

Publish and view test reporting directly in your GitHub Actions CI/CD workflow and Pull Requests with detailed test summaries, failed test analyses, and flaky test detection.
https://ctrf.io
MIT License
105 stars 9 forks source link

I cannot prevent publishing of PR comment when no tests failed, when generating a failed tests report? #20

Closed TylerKasper-Cova closed 2 months ago

TylerKasper-Cova commented 2 months ago

What

When I generate a failed tests report using github-actions-ctrf And I use a flag similar to --no-report-on-pass Then I should not see a PR comment posted to my PR

Why

A PR comment history can become quickly filled with a large number of comments saying "All tests passed" if you have a large number of commits in a draft PR / living PR. In my mind the status check being green is a good enough indicator to say that all of the tests have passed and that the build is safe.

If this is accomplishable by using another action that then pipes into the if: option of the step then adding that to the doc would be sufficient for me.

Ma11hewThomas commented 2 months ago

Thanks for the feedback, we have used on-fail-only arg in other libraries, I've added this here too. Published in v0.0.29

TylerKasper-Cova commented 2 months ago

Wow, that was very speedy. Thanks for your work! If you have a donate button for your work I'd love to throw a little something your way for the trouble.

Ma11hewThomas commented 2 months ago

You're welcome and thank you for the offer, although I won't be taking donations. The best way to help is to share the plugin with those you think it might be useful

Thanks again :)