Closed dmavrommatis closed 1 month ago
I see the trace and path being set correctly but I still do not see the annotation being created correctly. which field is passed to the annotation? trace or filepath?
and does it do any glob find in the repository to find the file or not?
readme needs to be updated to indicate we populate this new field. https://github.com/ctrf-io/go-ctrf-json-reporter/blob/main/README.md#test-object-properties
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
reporter/reporter.go | 0 | 10 | 0.0% | ||
<!-- | Total: | 0 | 10 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
reporter/reporter.go | 1 | 0.0% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 10888553733: | -1.1% |
Covered Lines: | 99 |
Relevant Lines: | 274 |
will address the comments when I find some time
I tested this and the annotations created by the CTRF reporter afterwards are still not working correctly (maybe it will work with -fullpath
but haven't tried).
Unfortunately I do not have much time to work on this so I will close the PR for now until someone else picks it up.
Addressing https://github.com/ctrf-io/go-ctrf-json-reporter/issues/10
The failed tests usually have the filename and the line number at the start of the printed message.
This PR uses a regex matcher to find that information and add it to the generated CTRF json.